Update dscp_transparency_test.go#5493
Conversation
AmrNJ
commented
May 21, 2026
AmrNJ
commented
- Added wait loops in DP-1.17 test to ensure all ATE tagged metrics are populated before validation.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the reliability of the DSCP transparency tests by introducing explicit wait conditions for ATE metrics. By ensuring that all tagged metrics are present before validation logic executes, the changes reduce flakiness caused by asynchronous data population in the test environment. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Pull Request Functional Test Report for #5493 / 88d36c7Virtual Devices
Hardware Devices
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces manual wait loops using time.Sleep in three test functions to ensure tagged metrics are populated before validation. Feedback indicates that these loops violate the repository style guide, which mandates using gnmi.Watch with .Await instead of time.Sleep. The reviewer also recommended refactoring the duplicated logic into a reusable helper function and optimizing the gNMI lookups to improve efficiency and maintainability.
3 participants
